Change location of jsonnet image - #645
Merged
Merged
Conversation
greenc-FNAL
requested review from
aolivier23,
knoepfel,
marcpaterno and
sabasehrish
as code owners
June 12, 2026 21:16
Contributor
📝 WalkthroughWalkthroughBoth GitHub Actions workflows for Jsonnet formatting are updated to pull the Jsonnet container image from ChangesJsonnet tooling Docker image updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
Author
✅ 7 CodeQL alerts resolved compared to main
Review the full CodeQL report for details. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/jsonnet-format-check.yaml:
- Line 79: Replace the floating tag "docker.io/dysnix/jsonnet:latest" with an
immutable digest reference (docker.io/dysnix/jsonnet@sha256:<digest>) in both
workflow usages mentioned (the image field in jsonnet-format-check.yaml and the
docker run invocation in jsonnet-format-fix.yaml); obtain the correct sha256
digest for the exact image you want (e.g., via docker pull + docker inspect or
manifest inspect) and update both occurrences so they match exactly to ensure
reproducible CI.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 5b729af3-5846-482c-a7b6-6ff539d034c1
📒 Files selected for processing (2)
.github/workflows/jsonnet-format-check.yaml.github/workflows/jsonnet-format-fix.yaml
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Analyze actions with CodeQL
- GitHub Check: scripts-test
🧰 Additional context used
🪛 zizmor (1.25.2)
.github/workflows/jsonnet-format-check.yaml
[error] 79-79: unpinned image references (unpinned-images): container image is pinned to latest
(unpinned-images)
knoepfel
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI/CD
public.ecr.aws/bitnami/jsonnet:latesttodocker.io/dysnix/jsonnet:latestjsonnet-format-check.yamljsonnet-format-fix.yaml